Skip to content

fix: ACNA-3928 - AIO_CLI_ENV not respected for deploy service URL#875

Merged
shazron merged 2 commits intomasterfrom
story/ACNA-3928
Jul 23, 2025
Merged

fix: ACNA-3928 - AIO_CLI_ENV not respected for deploy service URL#875
shazron merged 2 commits intomasterfrom
story/ACNA-3928

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Jul 22, 2025

Description

Fixes #872

How Has This Been Tested?

  • aio app deploy on Stage and Prod, by only changing AIO_CLI_ENV
  • used linked app plugin for Deploy Service

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MichaelGoberling
Copy link
Copy Markdown
Contributor

MichaelGoberling commented Jul 22, 2025

Looks like the log forwarding test needs an update, but besides that looks good

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (349420e) to head (477e173).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #875   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3263      3265    +2     
  Branches       631       631           
=========================================
+ Hits          3263      3265    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Jul 22, 2025

tests have been updated

@shazron shazron merged commit f0ae42e into master Jul 23, 2025
10 checks passed
@shazron shazron deleted the story/ACNA-3928 branch July 23, 2025 05:01
purplecabbage pushed a commit that referenced this pull request Nov 10, 2025
@shazron
fix: ACNA-3928 - AIO_CLI_ENV not respected for deploy service URL (#875)
53b13ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purplecabbage purplecabbage purplecabbage approved these changes

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AIO_CLI_ENV not respected for deploy service URL

3 participants

@shazron @MichaelGoberling @purplecabbage